瀏覽代碼

Simple fix for selecting which tracked key press to work off of for simple reactive effects (#5745)

XScorpion2 6 年之前
父節點
當前提交
3235c8527d

+ 2 - 1
quantum/rgb_matrix_animations/solid_reactive_anim.h

@@ -15,7 +15,8 @@ bool rgb_matrix_solid_reactive(effect_params_t* params) {
   for (uint8_t i = led_min; i < led_max; i++) {
     RGB_MATRIX_TEST_LED_FLAGS();
     uint16_t tick = max_tick;
-    for(uint8_t j = 0; j < g_last_hit_tracker.count; j++) {
+    // Reverse search to find most recent key hit
+    for (int8_t j = g_last_hit_tracker.count - 1; j >= 0; j--) {
       if (g_last_hit_tracker.index[j] == i && g_last_hit_tracker.tick[j] < tick) {
         tick = g_last_hit_tracker.tick[j];
         break;

+ 2 - 1
quantum/rgb_matrix_animations/solid_reactive_simple_anim.h

@@ -14,7 +14,8 @@ bool rgb_matrix_solid_reactive_simple(effect_params_t* params) {
   for (uint8_t i = led_min; i < led_max; i++) {
     RGB_MATRIX_TEST_LED_FLAGS();
     uint16_t tick = max_tick;
-    for(uint8_t j = 0; j < g_last_hit_tracker.count; j++) {
+    // Reverse search to find most recent key hit
+    for (int8_t j = g_last_hit_tracker.count - 1; j >= 0; j--) {
       if (g_last_hit_tracker.index[j] == i && g_last_hit_tracker.tick[j] < tick) {
         tick = g_last_hit_tracker.tick[j];
         break;